Use generic queries in the VM #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
force-pushed
the
refactor/more_generic_queries
branch
2 times, most recently
from
af2f919 to
3f795bd
Compare
niklaslong
approved these changes
Jun 3, 2025
vicsn
approved these changes
Jun 3, 2025
kaimast
reviewed
Jun 4, 2025
kaimast
reviewed
Jun 4, 2025
ledger/benches/transaction.rs
Outdated
| @@ -122,15 +142,20 @@ fn execute(c: &mut Criterion) { | |||
| vm.execute_authorization( | |||
| execute_authorization.replicate(), | |||
| Some(fee_authorization.replicate()), | |||
| None, | |||
| None::<Query<MainnetV0, <LedgerType<_> as ConsensusStorage<_>>::BlockStorage>>, | |||
There was a problem hiding this comment.
Should we add a helper function that returns None or the empty query from below?
There was a problem hiding this comment.
I'm not sure if that's possible (due to concrete/generic type as output), but this gave me the idea that I could introduce type aliases to greatly reduce the diff.
kaimast
approved these changes
Jun 4, 2025
ljedrz
force-pushed
the
refactor/more_generic_queries
branch
from
26b1325 to
0fe2c9c
Compare
vicsn
requested changes
Jun 4, 2025
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
ljedrz
force-pushed
the
refactor/more_generic_queries
branch
from
c7d2006 to
24845db
Compare
vicsn
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveats:
QueryTraitnow requires that the implementors areCloneNone), it gets recreated in functions that need to use it more than once; this is perfectly fine with the currentQueryobject, or if we assume the query to typically be providedThe 1st commit is the actual change, and the related diff is small; the second commit, and the vast majority of the PR's diff, is the formatting fallout from adjusting the tests to disambiguate the
Nonevalues.