Skip to content

Conversation

@ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Nov 5, 2025

While we don't use it yet, there is potential for utilizing RocksDB's secondary mode in node-adjacent tools which may want to have readonly access to a running node's ledger.

This PR extends the StorageMode::Custom to optionally accommodate a path for the secondary storage. It only requires minimal adjustments in snarkVM and snarkOS, and doesn't affect the current uses of StorageMode.

This is technically a breaking change, so I'm not sure what the new version(s) should be.

Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
@ljedrz ljedrz requested review from niklaslong and raychu86 November 5, 2025 14:31
Copy link
Collaborator

@niklaslong niklaslong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vicsn vicsn merged commit a974941 into ProvableHQ:main Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants