Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change _CoqProject separator settings #784

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Columbus240
Copy link
Contributor

@Columbus240 Columbus240 commented Aug 6, 2024

According to the code of coq_makefile, \r is not considered white-space in _CoqProject. But \t is. \t is considered white-space.
Source: https://github.com/coq/coq/blob/a7f51315db5d70888af3b96a579eb799a2b45ca9/lib/coqProject_file.ml#L84

The second commit of this PR removes a duplicate function definition.

@SkySkimmer
Copy link
Contributor

\r seems to be treated the same as \t and in that code?

@Columbus240
Copy link
Contributor Author

Oh! I'm sorry for the mistake.
Maybe just add \t then?

According to the code of coq_makefile, `\r` is not considered
white-space in _CoqProject.
(https://github.com/coq/coq/blob/a7f51315db5d70888af3b96a579eb799a2b45ca9/lib/coqProject_file.ml#L84)
Copy link
Contributor

@Matafou Matafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I shall merge soon if noone objects.

@Matafou Matafou merged commit 11dcebe into ProofGeneral:master Sep 5, 2024
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants