V1.4 release #14
Merged
V1.4 release #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to NetCore2.1 Refactored Merge branch 'master' into interactiveMessages Added Interactive buttons support Refactor StringSpliiter Check string Beauty & Comments
Added interactive button support
https://docs.mattermost.com/developer/interactive-messages.html#message-menus End implementation Message Menus
rgomez90
previously approved these changes
Oct 24, 2018
Added Message menus / Fix CI
rgomez90
previously approved these changes
Oct 29, 2018
Collaborator
|
@PromoFaux I added the examples, cleaned code & merged ManualTests into dev (#17). I think we are ready for release v1.4 😄 Next step SHOULD BE to write tests. Imho we should not move on without having a tested codebase. EDIT: PLEASE MERGE #18 before merging this PR. |
Cleaned code
Check for invalid StringSplitter maxChunk
Owner
Author
LGTM, just want to run through some final sanity checks before doing so though..! Will try and get to it on my lunch break today |
logic was reversed in refactor, however the ! was missed.
Owner
Author
|
OH WAIT. I've missed something very important. |
bump version number in appveyor.yml
Owner
Author
|
Something interesting to note (shouldn't affect anything at the moment as I'm yet to tag the release) Although appveyor has just built the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.