Skip to content

remove usage of NSSelectorFromString to avoid app review problems #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2017
Merged

remove usage of NSSelectorFromString to avoid app review problems #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29dda15
don't use NSSelectorFromString - Apple seems to be rejecting apps tha…
May 21, 2017
7b882d3
predeclare the method so that there is no warning
May 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/UIViewController+AnyPromise.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ @interface PMKGenericDelegate : NSObject <UINavigationControllerDelegate> {
+ (instancetype)delegateWithPromise:(AnyPromise **)promise;
@end


@interface UIViewController ()
- (AnyPromise*) promise;
@end

@implementation UIViewController (PromiseKit)

Expand Down Expand Up @@ -56,7 +58,7 @@ - (AnyPromise *)promiseViewController:(UIViewController *)vc animated:(BOOL)anim
}

if (!promise) {
if (![vc respondsToSelector:NSSelectorFromString(@"promise")]) {
if (![vc respondsToSelector:@selector(promise)]) {
id userInfo = @{NSLocalizedDescriptionKey: @"ViewController is not promisable"};
id err = [NSError errorWithDomain:PMKErrorDomain code:PMKInvalidUsageError userInfo:userInfo];
return [AnyPromise promiseWithValue:err];
Expand Down
2 changes: 1 addition & 1 deletion Tests/TestUIViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ private class MockViewController: UIViewController, Promisable {

var appeared = false

private override func viewDidAppear(_ animated: Bool) {
fileprivate override func viewDidAppear(_ animated: Bool) {
appeared = true
}
}