Merge pull request moby#30764 from tiborvass/stacktrace-debug-mode

Show stacktrace in daemon logs only if 500 internal error
Projjol-zz · Feb 6, 2017 · dc15fe8 · dc15fe8
2 parents e06ae6f + f7d9bb6
commit dc15fe8
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/api/server/server.go b/api/server/server.go
@@ -138,7 +138,12 @@ func (s *Server) makeHTTPHandler(handler httputils.APIFunc) http.HandlerFunc {
 		}
 
 		if err := handlerFunc(ctx, w, r, vars); err != nil {
-			logrus.Errorf("Handler for %s %s returned error: %+v", r.Method, r.URL.Path, err)
+			statusCode := httputils.GetHTTPErrorStatusCode(err)
+			errFormat := "%v"
+			if statusCode == http.StatusInternalServerError {
+				errFormat = "%+v"
+			}
+			logrus.Errorf("Handler for %s %s returned error: "+errFormat, r.Method, r.URL.Path, err)
 			httputils.MakeErrorHandler(err)(w, r)
 		}
 	}