fix docker stack volume's nocopy parameter

Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>
Projjol-zz · Feb 15, 2017 · 4fe6119 · 4fe6119
1 parent ed003ff
commit 4fe6119
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/cli/compose/convert/volume.go b/cli/compose/convert/volume.go
@@ -75,6 +75,9 @@ func convertVolumeToMount(volumeSpec string, stackVolumes volumes, namespace Nam
 
 	var volumeOptions *mount.VolumeOptions
 	if stackVolume.External.Name != "" {
+		volumeOptions = &mount.VolumeOptions{
+			NoCopy: isNoCopy(mode),
+		}
 		source = stackVolume.External.Name
 	} else {
 		volumeOptions = &mount.VolumeOptions{

diff --git a/cli/compose/convert/volume_test.go b/cli/compose/convert/volume_test.go
@@ -105,12 +105,38 @@ func TestConvertVolumeToMountNamedVolumeExternal(t *testing.T) {
 		Type:   mount.TypeVolume,
 		Source: "special",
 		Target: "/foo",
+		VolumeOptions: &mount.VolumeOptions{
+			NoCopy: false,
+		},
 	}
 	mount, err := convertVolumeToMount("outside:/foo", stackVolumes, namespace)
 	assert.NilError(t, err)
 	assert.DeepEqual(t, mount, expected)
 }
 
+func TestConvertVolumeToMountNamedVolumeExternalNoCopy(t *testing.T) {
+	stackVolumes := volumes{
+		"outside": composetypes.VolumeConfig{
+			External: composetypes.External{
+				External: true,
+				Name:     "special",
+			},
+		},
+	}
+	namespace := NewNamespace("foo")
+	expected := mount.Mount{
+		Type:   mount.TypeVolume,
+		Source: "special",
+		Target: "/foo",
+		VolumeOptions: &mount.VolumeOptions{
+			NoCopy: true,
+		},
+	}
+	mount, err := convertVolumeToMount("outside:/foo:nocopy", stackVolumes, namespace)
+	assert.NilError(t, err)
+	assert.DeepEqual(t, mount, expected)
+}
+
 func TestConvertVolumeToMountBind(t *testing.T) {
 	stackVolumes := volumes{}
 	namespace := NewNamespace("foo")