php8.3 support #66
Merged
php8.3 support #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProjektGopher
approved these changes
Feb 18, 2024
|
Sure! Did you run the tests before merging this to main! I was waiting for the result before merging it. It is failing on the main branch, and I think to fix this we shouldn't push the What do you think? |
|
I think you're right - I hadn't waited, I thought it had already run. I'm wondering now if my compiling the binary using 8.3 deps that'll create issues when someone is using 8.2/8.1 on their system |
|
I don't think this would be a problem since the conflict exists only in dev dependencies. |
|
Good point. Yeah I think adding the lock file to our gitignore and removing the file from the repo sounds like the right move. If I have time to sit at the computer after we get back from breakfast today I'll do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.