Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Task ] Update README.md #65

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

sebastianstucke87
Copy link
Contributor

Added a hint to automate whiskey update via Composer scripts.

Copy link
Owner

@ProjektGopher ProjektGopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to eventually have the update command be unnecessary. I'd like to register _all_hooks on install, but some hooks take arguments and I'm going to have to find some time to figure that out before that happens.

This is a good way to document this for now, but I'm not sure how I feel about maintainers forcing their project contributors to use it.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Len Woodward <len@projektgopher.com>
@ProjektGopher ProjektGopher merged commit 2ee58d0 into ProjektGopher:main Sep 25, 2023
@@ -77,7 +77,6 @@ Add Composer scripts to ensure consistent git hooks for all contributors of a pr
]
}
// ...
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ProjektGopher removing this broke the format in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants