Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Feat ] Add whisky validate command #45

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[ Feat ] Add whisky validate command #45

merged 2 commits into from
Aug 10, 2023

Conversation

faissaloux
Copy link
Contributor

Resolves #43

@ProjektGopher
Copy link
Owner

Does this just work by default without being added to config/commands.php? If that's the case, I wonder if we should remove the other items from that array since it's kind of unnecessary

@ProjektGopher ProjektGopher changed the title validate command [ Feat ] Add whisky validate command Aug 10, 2023
@ProjektGopher ProjektGopher merged commit b6474c9 into ProjektGopher:main Aug 10, 2023
@faissaloux
Copy link
Contributor Author

Does this just work by default without being added to config/commands.php? If that's the case, I wonder if we should remove the other items from that array since it's kind of unnecessary

Yeah it's working, no need to add it to config/commands.php. I'll remove all other commands from that add array in my next PR.

@faissaloux faissaloux deleted the validate-cmd branch August 10, 2023 18:49
@faissaloux faissaloux mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProjektGopher ProjektGopher ProjektGopher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Feat ] Add whisky validate command
2 participants
@faissaloux @ProjektGopher