Final switch to IMASDD #32
Merged
Commits on Mar 29, 2024
-
* All references to OMAS have been removed now. * All tests pass with IMASDD. * Minor changes in edge and cell initialization was required.
-
-
Speeding up by reducing calls to get_property
It was identified that majority of time is spent in get_property calls made due search_points and search_edges. Ithis commit reduces these calls by making a single clal per iteration of loop and storing the result in a temporary variable. This improved the speed by a factor of about 2. Before commit SOLPS2IMAS.jl % julia --project test/speedtest.jl ----------------------------------------------------------------------------- solps2imas(b2gmtry, b2output; b2mn=b2mn, fort=fort) time with compilation: 139.745324 seconds (433.19 M allocations: 16.150 GiB, 4.25% gc time, 40.88% compilation time: <1% of which was recompilation) solps2imas(b2gmtry, b2output; b2mn=b2mn, fort=fort) time (true runtime): 74.138648 seconds (267.65 M allocations: 4.938 GiB, 2.12% gc time, 0.02% compilation time) After commit SOLPS2IMAS.jl % julia --project test/speedtest.jl ----------------------------------------------------------------------------- solps2imas(b2gmtry, b2output; b2mn=b2mn, fort=fort) time with compilation: 139.745324 seconds (433.19 M allocations: 16.150 GiB, 4.25% gc time, 40.88% compilation time: <1% of which was recompilation) solps2imas(b2gmtry, b2output; b2mn=b2mn, fort=fort) time (true runtime): 74.138648 seconds (267.65 M allocations: 4.938 GiB, 2.12% gc time, 0.02% compilation time)
-
-
-
Using custom deepcopy_subset for faster deepcopy
After last commits, it was found that deepcopy of the grid_subsets done when triangular mesh is read is taking up about half of the computation time of solps2imas(). This is because deepcopy has to go through the deep grid_subset strucutre calling get_property at every instance. This commit uses custom deepcopy_subset function which is aware of the fields inside grid_subset and uses getfield() for faster access to items for creating deepcopy at julia base type level. This function has been added in GGDutils.jl/subset_tools.jl at ProjectTorreyPines/IMASggd.jl@3ebbf8f With this change, the speed has improved by a factor of 2.5. deepcopy is not a major bottleneck anymore.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.