Skip to content

Conversation

haiiro2gou
Copy link
Member

No description provided.

@haiiro2gou haiiro2gou requested a review from ChenCMD as a code owner September 20, 2025 20:18
@Copilot Copilot AI review requested due to automatic review settings September 20, 2025 20:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates player selectors across multiple game mechanics to exclude spectator and dead players from certain interactions. The change ensures that spectator mode players and players with the "Death" tag are not included in various game systems like portals, darkness effects, spawning mechanics, and boss encounters.

Key changes:

  • Updated player selectors to add gamemode=!spectator,tag=!Death filters
  • Applied changes consistently across portal systems, darkness mechanics, spawner systems, and boss encounter logic

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
return_to_overworld_portal/main.mcfunction Updated portal teleportation logic to exclude spectators and dead players
ending_portal/main.mcfunction Updated ending portal teleportation to exclude spectators and dead players
darkness/is_player_nearby/check.m.mcfunction Updated player proximity detection for darkness mechanics
darkness/.mcfunction Updated darkness penalty application to exclude spectators and dead players
anti_void_action/init.mcfunction Updated anti-void teleportation target selection
spawner/tick/.mcfunction Updated spawner player range detection
island/dispel/boss/watcher.mcfunction Updated boss despawn condition to exclude spectators

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@haiiro2gou haiiro2gou force-pushed the fix/spec-death-selector branch from e2e3edd to b423c69 Compare September 20, 2025 20:20
@haiiro2gou haiiro2gou changed the title 🐛 一部の処理におけるセレクターにおいてスペクテイター / 死亡中のプレイヤーを検知しないように 🐛 一部の処理においてスペクテイター / 死亡中のプレイヤーを検知しないように Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant