1426 no sidewalk context menu in tutorial #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1426
NoSidewalk was given a context menu by @maubinle in #1482. This PR just adds the relevant sections to the tutorial given the new context menu.
Here is what the tutorial looks like after you place the NoSidewalk label
And here is the tutorial after you rate the severity incorrectly (it should be a 3)
Note that I just took the GIFs from the missing sidewalk label, since all the GIFs are going to be redone very soon by @lstrobel anyway (#1281).
TO TEST:
Go through the tutorial and make sure you see these popups :) Also check that the progress bar increases appropriately as you rate severity (and doesn't go backwards at any point). Note that the progress bar should only increase once when rating severity (so if you get it wrong, then fix it, it should not increase a 2nd time).