"Nearly half of DC" text on the landing page updated #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Just double checking this: Do the stats for miles covered and labels placed disappear at 100%? This shouldn't happen IMO. |
|
@maddalihanumateja no they don't, I just didn't capture them in my screen shot, they are there still! |
…Webpage into 1159-landing-page-text
misaugstad
approved these changes
Oct 31, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1159
The text was no longer very relevant on the landing page for how much of DC has been audited. I changed the code so that there are two scenarios.
If DC has not yet completely been finished, the text says: Users like you have already mapped XXX miles of Washington DC--that's nearly XX% of the city!
Once DC hits 100%, it will say: We did it! Users like you have mapped all XXX miles of Washington DC. However, we are not done. The more users who contribute, the better quality data. So start mapping today!
Before
After
