Azure Quantum backend#439
Conversation
Pull Request Test Coverage Report for Build 2761899788
💛 - Coveralls |
|
@Takishima, Addressed rest of the active comments as well. Please review when you get a chance. Looks like few PR check failing are failing ( |
|
With regards the failures The coveralls problems are mostly due to to lack of test coverage in the following files: |
|
I have managed to fix the CI failure issues by making sure Otherwise, I think this PR looks good (though I will go through the code once more, but I don't expect to have anything else to complain about ;-) ) |
* Improve coveralls * Improve coveralls * Rename util.py to utils.py * Minor fixes * Update testcases * Update testcases
* Improve coveralls * Improve coveralls * Precommit reformatting
* Improve coveralls * Precommit formatting
|
@Takishima, we should be good with coveralls now. I got 100% coverage for azure-quantum modules. projectq/backends/_azure/_azure_quantum.py 158 0 100% |
|
Thanks for working that out. I will take another look at this next week. |
|
The current issues stems for the fact that from azure.quantum.target import IonQ, Quantinuum, Target
from azure.quantum.target.target_factory import TargetFactoryNB: this fails with the following error message: Is there any way to make this work with Python 3.6 and |
|
Actually I just saw that Python 3.6 has reached its EOL. I will merge another PR to remove 3.6 from the CI and then we can merge this. |
|
Just one more question. Otherwise I am happy to merge this. |
|
Closed PR by mistake, sorry about that :). |
|
Thanks @Takishima for great review comments and contributions to this PR. This has been great learning experience. I am looking forward to contributing more. Hoping to see this change in ProjectQ release soon :). |
* Merge master into develop branch (#436) * Preparing release vv0.7.2 * Fix missed bug in optimize.py * Fix typo in _optimize.py * Fix linters/formatters warnings * Update missed hooks * Hotfix: fix GitHub action workflows * Release version v0.7.3 (#435) * Merge master into develop branch (#431) * Preparing release vv0.7.2 * Fix missed bug in optimize.py * Fix typo in _optimize.py * Fix linters/formatters warnings * Update missed hooks * Hotfix: fix GitHub action workflows Co-authored-by: GitHub actions <noreply@github.com> Co-authored-by: Nguyen Damien <ngn.damien@gmail.com> * IonQ API: Move to v0.2, and fixup backends path (#433) * Move to v0.2, and fixup backends path The previous path was mistakenly incorrect, could we release this as a patch release of project-Q? Happy to help how I can. * changelog * fix * One more fixup * remove urljoin * fmt * Preparing release v0.7.3 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub actions <noreply@github.com> Co-authored-by: Nguyen Damien <ngn.damien@gmail.com> Co-authored-by: Jon Donovan <donovan@ionq.co> Co-authored-by: GitHub actions <noreply@github.com> Co-authored-by: Nguyen Damien <ngn.damien@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jon Donovan <donovan@ionq.co> * Bump docker/setup-qemu-action from 1 to 2 (#437) * Bump docker/setup-qemu-action from 1 to 2 Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v1...v2) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update CHANGELOG * Fix CentOS 7 build Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nguyen Damien <ngn.damien@gmail.com> * Fix setuptools-scm version for Python 3.6 (#440) * Add `blacken-docs` and `pyupgrade` to pre-commit configuration (#441) * Add `blacken-docs` and `pyupgrade` to pre-commit configuration * Apply new pre-commit hooks and fix related issues. * Update CHANGELOG * Fix unit tests failures * Fix pre-commit failure * Generalise the use of f-strings * Fix IonQ tests * Run `pyupgrade` before `isort` and `black` * Deprecate support for Python 3.6 (#442) * Azure Quantum backend (#439) * Add Azure Quantum backend template files * Add implementation of Azure Quantum * Add support for Honeywell and improve exception handling * Fixes and reformatting * Fixes and Improvements * Fixes and Improvements * Fixes and Improvements * Fixes and Improvements * Fix QASM transulation * Fixes and Improvements * Documentation related changes * Fix typos * Add docstrings to util methods * Fix typos * Add Unittests * Add Unittests * Add Unittests & rename honeywell to quantinuum * Fixes for QSAM convector * Add Unittests * Add Unittests * Add Unittests * Add Unittests * Fix Quantinuum Backend for Azure Quantum * Add Unittests * Add Unittests * Add Unittests * Add Unittests * Fix Vdag gate for IonQ backend * Minor updates * Update Docs * Add Azure Quantum example * Update README.rst * Update Docs * Update Docs * Update Unittests * Azure Quantum: CI Fixes (#4) * Azure Quantum: CI Fixes * Fix optional dependency problem * Update pre-commit reformatting * Fix pylint issues * Fix pylint issues * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Resolve comments (#5) * Resolve comments * Remove rearrange_result method from _utils.py * Update with pytest.approx for assert floating numbers * Pytest skipif testcases for Azure Quantum (#6) * Pytest skipif testcases for Azure Quantum * Fix projectq.backends._azure._exceptions import * Add common utils module (#7) * Create common utils module * Optimize _rearrange_result method * Make sure pip, setuptools and wheel packages are up to date on CI * Fix formatting issues from latest changes in develop branch * Improve coveralls (#8) * Improve coveralls * Improve coveralls * Rename util.py to utils.py * Minor fixes * Update testcases * Update testcases * Improve coveralls (#9) * Improve coveralls * Improve coveralls * Precommit reformatting * Improve coveralls (#10) * Improve coveralls * Precommit formatting * Fix CI failures * Avoid a few more #pragma: no cover * Fix flake8 warning * Remove one more # pragma: no cover * Reformat file Co-authored-by: Nguyen Damien <ngn.damien@gmail.com> * Fix installation on Apple Silicon and older Python versions (#444) * Preparing release v0.8.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub actions <noreply@github.com> Co-authored-by: Nguyen Damien <ngn.damien@gmail.com> Co-authored-by: Jon Donovan <donovan@ionq.co> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sai Seshu Chadaram <ssc1729@outlook.com>
Hi Team,
This is the PR to integrate Azure Quantum as backend to ProjectQ framework. As of now, Azure Quantum supports hardware and simulators from IonQ and Quantinuum targets.
Please review, welcome all feedback!
Thanks!