Add support for dynamic backends for IonQ#428
Add support for dynamic backends for IonQ#428Takishima merged 6 commits intoProjectQ-Framework:developfrom Cynocracy:dynamic-backends
Conversation
Pull Request Test Coverage Report for Build 2147249411
💛 - Coveralls |
Takishima
left a comment
There was a problem hiding this comment.
Hi @Cynocracy ,
Thank you for the PR. Before I can merge this, there are a few issues that I would like to see addressed apart the one comment:
- Add a new entry to the CHANGELOG
- Fix the issues from the linters/formatters [1] (NB: you can run them locally on your machine by using
pre-commit; let me know if you need help with that)
[1] https://github.com/ProjectQ-Framework/ProjectQ/runs/5697994650?check_suite_focus=true)
|
Don't worry about the CentOS CI failures. Those distros have reached EOL and will be fixed or removed from the CI in a separate PR. |
|
Also, could you please send an email to info@projectq.ch to request a link to sign the ProjectQ CLA? |
|
Thank you for the speedy review! Will take a look sometime today :) |
Using the backends endpoint, add available backends to the list.
Done, added changelog, and formatted things. Let me know what you think! Sorry if I missed anything |
There was a problem hiding this comment.
Thank you for the contribution. Just one more thing that may need clarification: I am not sure if you need to sign the CLA or if we could we use the fact that @amilstead signed it last time.
|
I double checked and it appears that we will have to require you to sign the ProjectQ CLA in order to merge these changes. Could you please send an email to info@projectq.ch requesting the link to sign the CLA? In the meantime I will try to work on a PR to address the CI issues. |
|
Sure! Sent an email but haven't gotten a response yet, should I send another? |
I cannot find trace of this email anywhere in the ProjectQ mailbox... Could you try again and CC me in the email (damien.nguyen@alumni.epfl.ch) If that one does not get through I will manually forward this to the right person. |
Thanks for re-sending the email, you should receive an email to sign the CLA shortly. Sorry about that delay. |
|
Thanks! Should I have the CLA now? Wasn't sure I saw it |
Yes, you should have received a mail about it by now. |
|
Got it now! Signed and returned :) |
I can confirm that from my end as well. I have just merged #429 so I just let the CI run once more and if everything looks good, I'll merge this. |
|
Thank you! |
Using the backends endpoint, add available backends to the list.