Skip to content

Add support for dynamic backends for IonQ#428

Merged
Takishima merged 6 commits intoProjectQ-Framework:developfrom
Cynocracy:dynamic-backends
Apr 11, 2022
Merged

Add support for dynamic backends for IonQ#428
Takishima merged 6 commits intoProjectQ-Framework:developfrom
Cynocracy:dynamic-backends

Conversation

@Cynocracy
Copy link
Contributor

Using the backends endpoint, add available backends to the list.

@coveralls
Copy link

coveralls commented Mar 25, 2022

Pull Request Test Coverage Report for Build 2147249411

  • 13 of 14 (92.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 99.986%

Changes Missing Coverage Covered Lines Changed/Added Lines %
projectq/setups/ionq.py 4 5 80.0%
Totals Coverage Status
Change from base Build 2147243803: -0.01%
Covered Lines: 7000
Relevant Lines: 7001

💛 - Coveralls

Copy link
Collaborator

@Takishima Takishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cynocracy ,

Thank you for the PR. Before I can merge this, there are a few issues that I would like to see addressed apart the one comment:

  • Add a new entry to the CHANGELOG
  • Fix the issues from the linters/formatters [1] (NB: you can run them locally on your machine by using pre-commit; let me know if you need help with that)

[1] https://github.com/ProjectQ-Framework/ProjectQ/runs/5697994650?check_suite_focus=true)

@Takishima
Copy link
Collaborator

Don't worry about the CentOS CI failures. Those distros have reached EOL and will be fixed or removed from the CI in a separate PR.

@Takishima
Copy link
Collaborator

Also, could you please send an email to info@projectq.ch to request a link to sign the ProjectQ CLA?

@Cynocracy
Copy link
Contributor Author

Thank you for the speedy review! Will take a look sometime today :)

Using the backends endpoint, add available backends to the list.
@Cynocracy Cynocracy requested a review from Takishima March 28, 2022 20:42
@Cynocracy
Copy link
Contributor Author

Also, could you please send an email to info@projectq.ch to request a link to sign the ProjectQ CLA?

Done, added changelog, and formatted things. Let me know what you think! Sorry if I missed anything

Copy link
Collaborator

@Takishima Takishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Just one more thing that may need clarification: I am not sure if you need to sign the CLA or if we could we use the fact that @amilstead signed it last time.

@Takishima
Copy link
Collaborator

I double checked and it appears that we will have to require you to sign the ProjectQ CLA in order to merge these changes.

Could you please send an email to info@projectq.ch requesting the link to sign the CLA?

In the meantime I will try to work on a PR to address the CI issues.

@Cynocracy
Copy link
Contributor Author

Sure! Sent an email but haven't gotten a response yet, should I send another?

@Takishima
Copy link
Collaborator

Sure! Sent an email but haven't gotten a response yet, should I send another?

I cannot find trace of this email anywhere in the ProjectQ mailbox... Could you try again and CC me in the email (damien.nguyen@alumni.epfl.ch)

If that one does not get through I will manually forward this to the right person.

@Takishima
Copy link
Collaborator

Sure! Sent an email but haven't gotten a response yet, should I send another?

Thanks for re-sending the email, you should receive an email to sign the CLA shortly. Sorry about that delay.

@Cynocracy
Copy link
Contributor Author

Thanks! Should I have the CLA now? Wasn't sure I saw it

@Takishima
Copy link
Collaborator

Thanks! Should I have the CLA now? Wasn't sure I saw it

Yes, you should have received a mail about it by now.

@Cynocracy
Copy link
Contributor Author

Got it now! Signed and returned :)

@Takishima
Copy link
Collaborator

Got it now! Signed and returned :)

I can confirm that from my end as well. I have just merged #429 so I just let the CI run once more and if everything looks good, I'll merge this.

@Takishima Takishima merged commit b22a278 into ProjectQ-Framework:develop Apr 11, 2022
@Cynocracy Cynocracy deleted the dynamic-backends branch April 13, 2022 17:09
@Cynocracy
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants