Skip to content

Fix typos #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 30, 2023
Merged

Fix typos #372

merged 16 commits into from
Mar 30, 2023

Conversation

@jnmorley
Copy link
Contributor

@jnmorley jnmorley commented Feb 12, 2023

Addresses Issue #337 chapters 10 - 20.

@review-notebook-app
Copy link

review-notebook-app bot commented Feb 12, 2023

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Feb 12, 2023 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 2bde762
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/372

@jnmorley
Copy link
Contributor Author

jnmorley commented Feb 28, 2023

For page 16 there is the following suggestion in the excel sheet:

The given description of FOSS may not be accurate. "Free" in FOSS generally means that there is freedom to redistribute, etc. If the software is also free of charge, more accurate terms may be FLOSS or GLOSS.

I don't know if I understand theses terms well enough to make a good judgement call here. If anyone has any suggestions on this, let me know and I can make the change and add it to this PR.

@jnmorley jnmorley marked this pull request as ready for review February 28, 2023 16:19
@jnmorley jnmorley requested a review from a team as a code owner February 28, 2023 16:19
@jnmorley jnmorley requested review from anissa111 and dopplershift and removed request for a team February 28, 2023 16:19
dopplershift
dopplershift requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up! I found a few other issues around the changes made here.

jukent and others added 4 commits March 16, 2023 13:31
@jukent @dopplershift
Update foundations/github/github-issues.md
2180118 
Co-authored-by: Ryan May <rmay31@gmail.com>
@jukent @dopplershift
Update foundations/conda.md
275e06b 
Co-authored-by: Ryan May <rmay31@gmail.com>
@jukent @dopplershift
Update foundations/github/github-repos.md
204fd11 
Co-authored-by: Ryan May <rmay31@gmail.com>
deleted far_left_cell.png image as it is no longer used
2a6b98d
@jnmorley jnmorley merged commit 35111ce into ProjectPythia:main Mar 30, 2023
github-actions bot pushed a commit that referenced this pull request Mar 30, 2023
@jnmorley @github-actions
Delete preview for pull request \#372
6aea8c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anissa111 anissa111 Awaiting requested review from anissa111 anissa111 is a code owner automatically assigned from ProjectPythia/education

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnmorley @dopplershift @jukent