Fix handling of long gallery card descriptions #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
brian-rose
requested review from
mgrover1,
erogluorhan and
jukent
and removed request for
a team
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201
The reason that the Vapor Cookbook is not showing up in the gallery (and the Regridding Cookbook is duplicated) is that its description is long enough to trigger a truncation operation (this line in
gallery_generator.py).This PR fixes a bug in that logic. The code for new card generation was in the
elseblock of that statement, so did not execute for any cookbook whose description requires truncation. The card from the previous iteration (in this case, the Regridding Cookbook) was added to the gallery again instead.Moving the new card generation code outside of the
if, elseblock seems to solve the issue.