fix: adapt benchmark memory allocation to device limits #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded 1GB memory allocation with dynamic calculation based on device capabilities. The benchmark now uses the smaller of 1GB or the device's maximum global buffer size, preventing allocation failures on devices with limited memory. Changes: - Calculate target memory as min(1024MB, device.max_global_buffer) - Derive N dynamically from available memory instead of fixed 4096*4096 - Reorder constant definitions for clarity - Add missing newline at end of file This makes the benchmark more robust and portable across different hardware configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced hardcoded 1GB memory allocation with dynamic calculation based on device capabilities. The benchmark now uses the smaller of 1GB or the device's maximum global buffer size, preventing allocation failures on devices with limited memory.
Changes:
This makes the benchmark more robust and portable across different hardware configurations.