Skip to content

document revert behavior where incorrect conduit key is provided#887

Merged
0age merged 1 commit into1.2from
dan/2023/01/document-non-enforcement-of-conduits
Jan 18, 2023
Merged

document revert behavior where incorrect conduit key is provided#887
0age merged 1 commit into1.2from
dan/2023/01/document-non-enforcement-of-conduits

Conversation

@DJViau
Copy link
Contributor

@DJViau DJViau commented Jan 18, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 66.05% // Head: 85.68% // Increases project coverage by +19.62% 🎉

Coverage data is based on head (3fdaf7c) compared to base (f1cc7b8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##              1.2     #887       +/-   ##
===========================================
+ Coverage   66.05%   85.68%   +19.62%     
===========================================
  Files         106       52       -54     
  Lines        4313     3101     -1212     
  Branches      547      413      -134     
===========================================
- Hits         2849     2657      -192     
+ Misses       1444      443     -1001     
+ Partials       20        1       -19     
Flag Coverage Δ
foundry 63.12% <ø> (+14.46%) ⬆️
production 99.76% <ø> (ø)
reference 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/foundry/token/StubERC20.sol
test/foundry/utils/ERC1155Recipient.sol
contracts/test/ConduitMock.sol
contracts/test/TestERC721.sol
contracts/test/ERC721ReceiverMock.sol
test/foundry/zone/impl/BadZone.sol
contracts/test/Reenterer.sol
offerers/TestPoolOfferer.sol
test/foundry/token/StubERC721.sol
test/foundry/utils/BaseConsiderationTest.sol
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0age 0age merged commit 778b5e3 into 1.2 Jan 18, 2023
@0age 0age deleted the dan/2023/01/document-non-enforcement-of-conduits branch January 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants