Conversation
Codecov ReportBase: 85.68% // Head: 85.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 1.2 #885 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 52 52
Lines 3101 3101
Branches 413 413
=======================================
Hits 2657 2657
Misses 443 443
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for constants, per https://github.com/spearbit-audits/review-seaport-1.2/issues/46
Note that it also adds TokenTransferGenericFailure_error_selector to ConsiderationConstants.sol, which might be bad form or have consequences I don't anticipate, so please comment liberally.