Skip to content

Ensure revert on non-zero token / identifier (native) and identifier (erc20) in transferred item params#485

Merged
0age merged 18 commits intomainfrom
unused-parameters-tests
Jun 11, 2022
Merged

Ensure revert on non-zero token / identifier (native) and identifier (erc20) in transferred item params#485
0age merged 18 commits intomainfrom
unused-parameters-tests

Conversation

@stephankmin
Copy link
Contributor

@stephankmin stephankmin commented Jun 9, 2022 •
edited
Loading

  • test revert when token address and/or identifier is set for native consideration item when calling fulfillBasicOrder or fulfillOrder
  • test revert when identifier is set for erc20 offer/consideration item when calling fulfillBasicOrder or fulfillOrder

@emo-eth emo-eth force-pushed the unused-parameters-tests branch from f355129 to ba5e510 Compare June 10, 2022 19:47
@stephankmin stephankmin changed the title [WIP] Ensure revert on non-zero token / identifier (native) and identifier (erc20) in transferred item params Ensure revert on non-zero token / identifier (native) and identifier (erc20) in transferred item params Jun 11, 2022
@0age 0age merged commit 1a65f0e into main Jun 11, 2022
@0age 0age deleted the unused-parameters-tests branch June 11, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephankmin @0age @emo-eth