Extract a styled CompanionWindowSection
#3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
mui5-companion-windo
branch
from
2df69b3
to
0b5121f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## mui5 #3820 +/- ##
==========================================
- Coverage 92.57% 92.54% -0.04%
==========================================
Files 201 202 +1
Lines 3556 3554 -2
==========================================
- Hits 3292 3289 -3
- Misses 264 265 +1 ☔ View full report in Codecov by Sentry. |
marlo-longley
approved these changes
Nov 28, 2023
jcoyne
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think extracting components is probably preferable to inline style definitions that use a mix of
styled-componentsandsx?