Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OpenSeadragonViewer tests compatible with OpenSeadragon 2.4.2 #3798

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

lutzhelm
Copy link
Contributor

@lutzhelm lutzhelm commented Nov 1, 2023

As described in discussion #3792 and discussed in the last community call, the package.json allows all OSD versions from 2.4.2 on, but the getViewer function that is used in the test is not available in 2.4.2. If version 2.4.2 is installed, the tests will fail.

Tests would previously fail if OSD version 2.4.2 was installed.
See  #3792
@cbeer cbeer merged commit 222378a into master Nov 1, 2023
8 checks passed
@cbeer cbeer deleted the discussion-3792-osd-test-version-compatibility branch November 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants