Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mui5 test fixups #3795

Closed
wants to merge 15 commits into from
Closed

Mui5 test fixups #3795

wants to merge 15 commits into from

Conversation

barmintor
Copy link
Contributor

Largely restoring marker classes used in tests, but there is a less ambiguous change:

  • recent Material-UI uses a different role (combobox) for select elements (previously button)

This PR can otherwise be used to point to specs that need to have a select on the marker class removed - every commit should point to one failing test.

marlo-longley and others added 15 commits October 27, 2023 11:20
@marlo-longley @barmintor
Run CI tests when making PRs against the mui5 branch
3e61f5d
@barmintor
selected Thumbnails have class 'selected'
27c1515
@barmintor
ManifestListItem component sets selected from active prop, has class …
1e2e23d 
…'active' when selected
@barmintor
WorkspaceArea component has Mui5 light grey background
786f191
@barmintor
SearchHit component ListItems have class 'windowSelected' if inidicat…
9f8b83d 
…ed in props
@barmintor
CompanionArea component uses namespaced position class and includes c…
3e854a2 
…onfigured area layout from props
@barmintor
CompanionWindow component renders layout and size classes configured …
e93af81 
…in pros
@barmintor
SanitizedHtml component renders root class configured in props
31cdaac
@barmintor
ScrollIndicatedDialogContent component renders configured shadowScrol…
1dcb06d 
…lDialog class if given in props
@barmintor
mui v5.10.15+ Select has role 'combobox'
22bf184 
- mui/material-ui@d59f395
@barmintor
WindowSideBar component renders configured drawer class name from pro…
0b41579 
…ps if configured
@barmintor
ZoomControls renders divider with configured className from props if …
2ef6e8b 
…given
@barmintor
WindowTopMenuButton renders configured ctrlBtnSelected from props on …
d200640 
…open windows if configured
@barmintor
WorkspaceElasticWindow renders configured focused className if given …
efcce38 
…and element is focused
@barmintor
remove cn and use namespaced class on Window component
5368237
@barmintor barmintor marked this pull request as ready for review October 27, 2023 15:29
cbeer added a commit that referenced this pull request Nov 21, 2023
@cbeer
Merge pull request #3804 from ProjectMirador/3795-mui5-tests-rebased
0847e2a 
Rebased #3795
@cbeer
Copy link
Collaborator

cbeer commented Nov 21, 2023

Merged in #3804.

@cbeer cbeer closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barmintor @cbeer @marlo-longley