Added support for ethereum keys and signatures#267
Merged
Conversation
aramikm
requested review from
JoeCap08055,
enddynayn,
mattheworris,
shannonwells and
wilwade
JoeCap08055
reviewed
Jun 12, 2025
JoeCap08055
reviewed
Jun 12, 2025
JoeCap08055
reviewed
Jun 12, 2025
JoeCap08055
reviewed
Jun 12, 2025
JoeCap08055
reviewed
Jun 16, 2025
JoeCap08055
approved these changes
Jun 16, 2025
Contributor
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
Looks good; all of my issues have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for ethereum signatures and provider keys.
Added a new config param named
ETHEREUM_PROVIDER_ACCOUNT_PRIVATE_KEYwhich is mutually exclusive withPROVIDER_ACCOUNT_SEED_PHRASE.Closes frequency-chain/frequency#2283
Verification