Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor payload types for account-service webhooks to come from OpenAPI spec, so they can be shared with consuming clients #542

Conversation

JoeCap08055
Copy link
Contributor

Description

This PR refactors the enum & payload types used in the account-service webhooks into an OpenAPI 3.1 spec document, and adds tooling to generate Typescript types from there. This allows us to share the OpenAPI spec with clients that wish to implement webhook callbacks.

Closes #457

…m OpenAPI spec, so they can be shared with consuming clients
@JoeCap08055 JoeCap08055 linked an issue Sep 20, 2024 that may be closed by this pull request
3 tasks
@JoeCap08055 JoeCap08055 requested a review from aramikm September 20, 2024 02:52
Copy link
Contributor

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@JoeCap08055 JoeCap08055 merged commit 9850994 into main Sep 20, 2024
13 checks passed
@JoeCap08055 JoeCap08055 deleted the 457-generate-webhook-request-and-response-datatypes-from-openapi-spec-document branch September 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate webhook request and response datatypes from OpenAPI spec document.
2 participants