Conversation
Add normal summon target Add VFD Stun to dark Add Fairytail luna bounce Add ZefraWar Routine bugfix zefraath search (still need testing)
bugfix scale completition routine bugfix fairytail luna, still not working as intended for some reason
hack fairy tail luna change how some card should be used
add case to handle scale completition add hack to differentiate between pendulum summon and using gamma
kevinlul
left a comment
kevinlul
left a comment
There was a problem hiding this comment.
Hey, thanks for submitting this executor and sorry it took so long to come around and review! I have some concerns about the effectiveness of the deck submitted and code quality. Please have a look at the individual comments so far.
| 88581108 | ||
| 23935886 | ||
| !side | ||
|
|
There was a problem hiding this comment.
Is there a specific reason why the deck is in this order instead of being sorted? The deck also seems to brick a lot so you might want to reconsider your ratios and strategies. The Extra Deck also contains only 13 cards.
There was a problem hiding this comment.
Is there any sort of metric I can use to tune the deck? something like at least 1 negate over 75% of the time or something. Do I have to make it as competitive as possible with very low margin of error?
There was a problem hiding this comment.
There isn't a particular metric but I found that the deck was bricking very often and not getting any plays off because of the ratios. Zefraath pass is not a particularly convincing first-turn play. It doesn't have to be as competitive as possible in the meta sense, but it should certainly do something instead of consistently losing to Normal monster mash.
| <ItemGroup> | ||
| <Compile Include="Config.cs" /> | ||
| <Compile Include="Game\AI\Deck.cs" /> | ||
| <Compile Include="Game\AI\Decks\ZefraControlExecutor.cs" /> |
There was a problem hiding this comment.
Move this entry to be adjacent to the other executors.
| public const int OracleZefra = 32354768; | ||
| public const int ZefraWar = 96073342; | ||
| public const int ZefraDivineStrike = 35561352; | ||
| public const int NinePilalrs = 57831349; |
| public const int VampiricDragon = 93713837; | ||
| public const int TrueKingVFD = 88581108; | ||
| public const int DracoMasterOfTenyi = 23935886; | ||
| public const int PsyframelordLambda = 8802510; |
| public const int StardustChargeWarrior = 64880894; | ||
| public const int EarthSlicer = 97584719; | ||
| public const int Enterblathnir = 95113856; | ||
| public const int PtolemyM7 = 38495396; |
| for (int i = 1; i <= max; ++i) | ||
| { | ||
|
|
||
| ClientCard card = cards[cards.Count - i]; |
| return true; | ||
| } | ||
| //AI.SelectMaterials(); | ||
| return false; |
| } | ||
| } | ||
| if (selected.Count == 0) | ||
| selected.Add(cards[cards.Count - 1]); |
| return false; | ||
| } | ||
| private bool CrocoDragonTrigger() { | ||
| if (ActivateDescription == Util.GetStringId(CardId.Crocodragon, 0)) { |
| } | ||
| private bool OracleTrigger() { | ||
| if (ActivateDescription == Util.GetStringId(CardId.OracleZefra, 1)) { | ||
|
|
edo9300
force-pushed
the
master
branch
2 times, most recently
from
5e16a86 to
7691b54
Compare
2 participants
Add ZefraControl deck
Still need to use some hack to deals with pendulum summoning due to usual function is not executable.