Skip to content

* Skip temporary/memory files from PackageNotIncludedInGit warning #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

* Skip temporary/memory files from PackageNotIncludedInGit warning #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions Source/GitSourceControl/Private/GitSourceControlUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,37 @@ void FGitLockedFilesCache::OnFileLockChanged(const FString& filePath, const FStr

namespace GitSourceControlUtils
{
bool IsMeantToBeSaved(const FString& InFilePath)
{
FString PackageName;
if (!FPackageName::TryConvertFilenameToLongPackageName(InFilePath, PackageName))
{
return false;
}

UPackage* Package = FindPackage(nullptr, *PackageName);
if (!Package)
{
// Try loading the package if it is not already loaded
Package = LoadPackage(nullptr, *PackageName, LOAD_None);
if (!Package)
{
return false;
}
}
// Ignore the packages that aren't meant to be persistent.
if (Package->HasAnyFlags(RF_Transient) ||
Package->HasAnyPackageFlags(PKG_CompiledIn) ||
Package->HasAnyPackageFlags(PKG_PlayInEditor) ||
Package == GetTransientPackage() ||
FPackageName::IsMemoryPackage(Package->GetPathName()))
{
return false;
}

return true;
}

FString ChangeRepositoryRootIfSubmodule(TArray<FString>& AbsoluteFilePaths, const FString& PathToRepositoryRoot)
{
FString Ret = PathToRepositoryRoot;
Expand All @@ -147,8 +178,11 @@ namespace GitSourceControlUtils
if (TestPath.IsEmpty())
{
// TestPath.IsEmpty() meaning is that FilePath is not git file. So it need to removed to git command file list.
PackageNotIncludedInGit.Add(FilePath);
UE_LOG(LogSourceControl, Warning, TEXT("Package file to update has included dependent file is not git or Can't find directory path for file : %s"), *FilePath);
if (IsMeantToBeSaved(FilePath))
{
PackageNotIncludedInGit.Add(FilePath);
UE_LOG(LogSourceControl, Warning, TEXT("Package file to update has included dependent file is not git or Can't find directory path for file : %s"), *FilePath);
}

break;
}
Expand Down