Updated hasHarness check #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current harness check only checks to see if you have a harness in your inventory and not actually attached. This change will make it only show the icon if the harness has been used(attached) otherwise it's technically showing you have the harness but you don't have it attached, which kind of defeats the purpose of the icon. Not sure if there is a better way of doing this, but it works and has been tested. https://nooby.xyz/nooby/f/FcYqoL-05-06-2022.mp4
Member
|
Tested myself and works. Thanks for the PR 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current harness check only checks to see if you have a harness in your inventory and not actually attached.
This change will make it only show the icon if the harness has been used(attached) otherwise it's technically showing you have the harness but you don't have it attached, which kind of defeats the purpose of the icon.
Not sure if there is a better way of doing this, but it works and has been tested.
https://nooby.xyz/nooby/f/FcYqoL-05-06-2022.mp4 (Video showing it works)