Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include model fixed parameters in sample_lhs result #4

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

saschaishikawa
Copy link
Contributor

@dhadka: I've been using fixed_parameters to pass in Model parameters that are constant (but may change between experiments). For instance,

model.fixed_parameters.update({
    "constant_param1": 2045, 
    "constant_param2": 20
})

However, I run into problems evaluating the SOWs generated by sample_lhs(), since fixed_parameters aren't included in it and the model still expects these as parameters. I figured instead of running this each time:

SOWs = sample_lhs(model, 10)
results1 = evaluate(model, update(SOWs, {"constant_param1": 2045, "constant_param2":20}) )
results2 = evaluate(model, update(SOWs, {"constant_param1": 2050, "constant_param2":15}) )

could we have sample_lhs automatically pass along the constants in the SOWs? Are there cases when we wouldn't want this to happen?

@dhadka dhadka merged commit f859dfc into Project-Platypus:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants