Emit warning when osrm-extract encounters ways referencing missing nodes #7351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1596
When an OSM file has
<way>elements referencing<node>elements that don't exist,osrm-extractprocesses the file silently. Users get no indication their input data has problems, making it difficult to diagnose issues in later pipeline stages.The extractor already handles this correctly at the code level --
PrepareNodes()filters out missing node references andPrepareEdges()marks edges with invalid nodes asSPECIAL_NODEID. However, the existing debug-level messages are only visible with--verbosity DEBUG.This PR adds a
logWARNINGthat is visible at the default log level.Missing boundary nodes are expected for bounding-box extracts, so extraction still succeeds -- the warning simply informs the user about the count of dropped nodes.
Tasklist
Requirements / Relations
None