Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Jan 12, 2025

Issue

no member named 'construct' in 'optional<type-parameter-0-0 &>' error in with Clang 19 #7097

Changes

  • Update to Alpine Linux 3.21.2 and update the packages (to match Dockerfile-debian)
  • Install the 3 common boost-* packages already in the alpine-mimalloc stage
  • Fix no member named 'construct' in 'optional<type-parameter-0-0 &>' error in sol.hpp with Clang 19
  • Fix Policy CMP0167 is not set: The FindBoost module is removed with cmake 3.31.1
  • Change the boost release URL to GitHub, to fix the CI build error "stdin: not in gzip format"

- Fix no member named 'construct' in 'optional<type-parameter-0-0 &>' error in sol.hpp with Clang 19
- Fix Policy CMP0167 is not set: The FindBoost module is removed with cmake 3.31.1
@afarber
Copy link
Contributor Author

afarber commented Jan 12, 2025

@DennisOSRM and @SiarheiFedartsou could you please review my pull request?

I am attaching the broken and the fixed logs here:

alpine-3.21.2-BROKEN.txt
alpine-3.21.2-FIXED.txt

@DennisOSRM
Copy link
Collaborator

Started CI builds

@afarber
Copy link
Contributor Author

afarber commented Jan 13, 2025

Hi @DennisOSRM does CI build maybe have the same issue as @SiarheiFedartsou had with my previous PR?

gzip: stdin: not in gzip format because boost is temporarily not available at the Jfrog repo?

Could you please restart the CI build?

@afarber
Copy link
Contributor Author

afarber commented Jan 24, 2025

@DennisOSRM could you please approve again, now that the boost download issue in CI is fixed?

@SiarheiFedartsou SiarheiFedartsou merged commit 61464fc into Project-OSRM:master Jan 25, 2025
21 of 22 checks passed
@SiarheiFedartsou
Copy link
Member

Thanks!

eliseier pushed a commit to wanderlog/osrm-backend that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants