Skip to content

Conversation

@SiarheiFedartsou
Copy link
Member

@SiarheiFedartsou SiarheiFedartsou commented May 19, 2024

Issue

gcc 13 was removed from ubuntu-22.04 image: actions/runner-images#9854

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

Benchmark Results

Benchmark Base PR
alias aliased u32: 1094.61
plain u32: 1092.49
aliased double: 958.881
plain double: 959.044
aliased u32: 1096.54
plain u32: 1092.85
aliased double: 945.156
plain double: 958.948
json-render String: 8.56098ms
Stringstream: 11.6958ms
Vector: 7.61092ms
String: 8.55523ms
Stringstream: 11.6943ms
Vector: 7.62153ms
match_ch 8.23188ms/req at 82 coordinate
0.100389ms/coordinate
8.25988ms/req at 82 coordinate
0.10073ms/coordinate
match_mld 7.13153ms/req at 82 coordinate
0.0869699ms/coordinate
7.11101ms/req at 82 coordinate
0.0867196ms/coordinate
packedvector random write:
std::vector 9724.03 ms
util::packed_vector 74559.1 ms
slowdown: 7.66751
random read:
std::vector 8436.93 ms
util::packed_vector 30553.2 ms
slowdown: 3.62136
random write:
std::vector 9789.71 ms
util::packed_vector 82284.8 ms
slowdown: 8.40523
random read:
std::vector 8464 ms
util::packed_vector 33239.2 ms
slowdown: 3.92713
rtree 1 result:
201.029ms -> 0.0201029 ms/query
10 results:
237.173ms -> 0.0237173 ms/query
1 result:
207.224ms -> 0.0207224 ms/query
10 results:
242.478ms -> 0.0242478 ms/query

@SiarheiFedartsou SiarheiFedartsou changed the title Attempt to fix failing CI on gcc-13 jobs Fix failing gcc-13 based CI jobs May 19, 2024
@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review May 19, 2024 13:03
@DennisOSRM
Copy link
Collaborator

Interesting that they removed the version 13 compiler from the 22.04 image.

@DennisOSRM DennisOSRM merged commit 11c7ddc into master May 19, 2024
@DennisOSRM DennisOSRM deleted the sf-gcc-13-fix branch May 19, 2024 17:30
eliseier pushed a commit to wanderlog/osrm-backend that referenced this pull request Mar 25, 2025
* Attempt to fix failing CI on gcc-13 jobs

* Attempt to fix failing CI on gcc-13 jobs

* Attempt to fix failing CI on gcc-13 jobs

* Attempt to fix failing CI on gcc-13 jobs

* Attempt to fix failing CI on gcc-13 jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants