Fix some compilation issues on modern macOS systems #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound some boost 1.8 bugs
SiarheiFedartsou
approved these changes
Oct 12, 2023
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple clang 15 doesn't like some of our coding practices, notably some use of:
where we're not interested in the return values, just the side-effects of the lambda functions. This PR adds dummy variables to hold the results, and marks them as
[[maybe_unused]], which appeases the compiler.I've also thrown in a workaround to boostorg/phoenix#111 which is preventing things from building when compiled against Boost 1.8x, which is the current version available in Homebrew on macOS.
I haven't actually tested anything here, I just know it all compiles cleanly on my Apple M1 machine now.
Should address most of #6707 - I didn't observe the issues with
std::unary_functionwhen using Boost 1.8x