Fix a couple of warnings found by PVS Studio #6372
Conversation
| # Linux dev packages | ||
| if [ "${TARGET_ARCH}" != "i686" ] && [ "${ENABLE_CONAN}" != "ON" ]; then | ||
| sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y |
There was a problem hiding this comment.
It started failing unexpectedly, but it turned out that we probably don't need it :)
There was a problem hiding this comment.
Yes I think we're lucky that 20.04 supports the 5 gcc versions in our matrix. If the distro and matrix get out of sync, we'll need to bring it back (or just limit it to the versions the distro supports).
|
@mjjbell please take a look when you have a chance :) |
mjjbell
left a comment
mjjbell
left a comment
There was a problem hiding this comment.
Is this something we can run continuously?
I see they have a docs page for running via Github Actions: https://pvs-studio.com/en/docs/manual/6579/
| # Linux dev packages | ||
| if [ "${TARGET_ARCH}" != "i686" ] && [ "${ENABLE_CONAN}" != "ON" ]; then | ||
| sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y |
There was a problem hiding this comment.
Yes I think we're lucky that 20.04 supports the 5 gcc versions in our matrix. If the distro and matrix get out of sync, we'll need to bring it back (or just limit it to the versions the distro supports).
We definitely can, will try to look into it at some point. Btw will you be able to take a look into other opened PRs? you probably missed notifications about them(or just don’t have time for it, not sure if you have enough time at the moment) |
Issue
I asked for a PVS Studio license for us(they give it for free for open source projects) and it was able to find a couple of issues like this.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?