-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Description
Hello,
In the bicycle OSRM profile, there is a check for the bicycle highway tag in the safety_handler function.
osrm-backend/profiles/bicycle.lua
Lines 546 to 560 in 06b1b98
| if data.highway == "bicycle" then | |
| safety_bonus = safety_bonus + 0.2 | |
| if result.forward_speed > 0 then | |
| -- convert from km/h to m/s | |
| result.forward_rate = result.forward_speed / 3.6 * safety_bonus | |
| end | |
| if result.backward_speed > 0 then | |
| -- convert from km/h to m/s | |
| result.backward_rate = result.backward_speed / 3.6 * safety_bonus | |
| end | |
| if result.duration > 0 then | |
| result.weight = result.duration / safety_bonus | |
| end | |
| end |
However, unless I am mistaken, there is no highway=bicycle tag in OSM, but rather a highway=cycleway tag: https://wiki.openstreetmap.org/wiki/Key:highway
Therefore, shouldn't this code check for "cycleway" rather than "bicycle"?
Thanks!
Metadata
Metadata
Assignees
Labels
No labels