Skip to content

Conversation

@Can-Zhao
Copy link
Contributor

Fixes #1458 .

Description

Reduce scale factor and val loss across ranks for DDP

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Can-Zhao added 2 commits July 17, 2023 15:57
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao Can-Zhao requested a review from guopengf July 17, 2023 23:38
@Can-Zhao Can-Zhao marked this pull request as ready for review July 17, 2023 23:38
@Can-Zhao Can-Zhao marked this pull request as draft July 17, 2023 23:38
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review July 21, 2023 01:01
Copy link
Contributor

@guopengf guopengf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guopengf guopengf merged commit d0de28e into Project-MONAI:main Jul 24, 2023
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
…1461)

Fixes Project-MONAI#1458 .

### Description
Reduce scale factor and val loss across ranks for DDP

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce scale factor for DDP in generative model

2 participants