Skip to content

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 16, 2023

follow-up of Project-MONAI/MONAI#6008, adding more examples

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.

wyli added 2 commits February 16, 2023 13:25
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) February 16, 2023 13:36
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit 4d4c565 into Project-MONAI:main Feb 16, 2023
@wyli wyli deleted the enhance-load-image-tutorial branch February 16, 2023 13:48
@mingxin-zheng
Copy link
Contributor

Hi @wyli , I am curious if the # noqa: N813 in import SimpleITK as sitk # noqa: N813 affects any of cicd pipelines in the tutorial repo?

boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
follow-up of Project-MONAI/MONAI#6008, adding
more examples

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants