update validation for argo task args and argo k8 keys #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodheadio
approved these changes
May 3, 2023
lillie-dae
approved these changes
May 3, 2023
lillie-dae
reviewed
May 3, 2023
src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
samrooke
force-pushed
the
samrooke/AC-2184-validate-argo-args
branch
from
5512896 to
a7998fd
Compare
samrooke
commented
May 3, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This issue has been resolved in version 0.1.11 🎉 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added validation around acceptable keys for argo tasks. Also fixes an issue with the properties provided to argo when we override resource limits based on the workflow specification provided.
Status
Ready
Types of changes