Skip to content

Add notifications onto CR Event #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Add notifications onto CR Event #736

merged 4 commits into from
Apr 11, 2023

Conversation

JoeBatt1989
Copy link
Contributor

Description

Adds notifications property onto a CR Event

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • [ x] Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • [x ] New tests added to cover the changes.
  • [x ] All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Joe Batt <joe.batt@answerdigital.com>
Signed-off-by: Joe Batt <joe.batt@answerdigital.com>
Signed-off-by: Joe Batt <joe.batt@answerdigital.com>
Signed-off-by: Joe Batt <joe.batt@answerdigital.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JoeBatt1989 JoeBatt1989 merged commit 79b1a2a into develop Apr 11, 2023
@neildsouth neildsouth mentioned this pull request Apr 11, 2023
7 tasks
@neildsouth neildsouth added this to the 0.1.18 milestone Apr 11, 2023
@neildsouth neildsouth added the enhancement New feature or request label Apr 11, 2023
JoeBatt1989 added a commit that referenced this pull request Apr 17, 2023
* Add notifications onto CR Event

Signed-off-by: Joe Batt <joe.batt@answerdigital.com>

* Add notifications onto CR Event

Signed-off-by: Joe Batt <joe.batt@answerdigital.com>

* Add notifications onto CR Event

Signed-off-by: Joe Batt <joe.batt@answerdigital.com>

* Add notifications onto CR Event

Signed-off-by: Joe Batt <joe.batt@answerdigital.com>

---------

Signed-off-by: Joe Batt <joe.batt@answerdigital.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.8 🎉

The release is available on:

@mocsharp mocsharp deleted the CR-Notifications branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants