Skip to content

AC-2032 Readded the notification preferences validation #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

AC-2032 Readded the notification preferences validation #732

merged 1 commit into from
Apr 6, 2023

Conversation

woodheadio
Copy link
Collaborator

Description

Re-introduces previously reverted code for notification preferences.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@woodheadio woodheadio requested a review from answeranand April 6, 2023 09:06
@woodheadio
AC-2032 Readded the notification preferences validation
8953e5b 
Signed-off-by: Alex Woodhead <11213454+woodheadio@users.noreply.github.com>
@woodheadio woodheadio force-pushed the AC-2032-ReaddNotificationPreferences branch from 684a256 to 8953e5b Compare April 6, 2023 09:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@woodheadio woodheadio merged commit a9b9ae9 into develop Apr 6, 2023
@woodheadio woodheadio added the enhancement New feature or request label Apr 6, 2023
@woodheadio woodheadio added this to the 0.1.7 milestone Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This issue has been resolved in version 0.1.7 🎉

The release is available on:

@mocsharp mocsharp deleted the AC-2032-ReaddNotificationPreferences branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNuttall-AD DanielNuttall-AD DanielNuttall-AD approved these changes

@answeranand answeranand Awaiting requested review from answeranand

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@woodheadio @DanielNuttall-AD