Event validation & add Task related events - #7
Merged
Conversation
Add validation to events. Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Codecov Report
@@ Coverage Diff @@
## release/0.1.0 #7 +/- ##
=======================================================
+ Coverage 93.77778% 94.88927% +1.11148%
=======================================================
Files 19 24 +5
Lines 450 587 +137
Branches 15 32 +17
=======================================================
+ Hits 422 557 +135
+ Misses 24 22 -2
- Partials 4 8 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Victor Chang <vicchang@nvidia.com>
mocsharp
force-pushed
the
vchang/task-message-definitions
branch
from
April 8, 2022 19:11
c061a88 to
0ccaabd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mocsharp
marked this pull request as ready for review
April 8, 2022 19:27
jeanpatrickleger
pushed a commit
that referenced
this pull request
Jun 14, 2022
* Rename Message to Event used in the message body. * Add validation to events and validate event messages on all properties recursively. Signed-off-by: Victor Chang <vicchang@nvidia.com> Signed-off-by: JP LEGER <jeanpatrick.leger@gmail.com>
mocsharp
added a commit
that referenced
this pull request
Jun 27, 2022
* Rename Message to Event used in the message body. * Add validation to events and validate event messages on all properties recursively. Signed-off-by: Victor Chang <vicchang@nvidia.com>
mocsharp
added a commit
that referenced
this pull request
Jun 27, 2022
* Rename Message to Event used in the message body. * Add validation to events and validate event messages on all properties recursively. Signed-off-by: Victor Chang <vicchang@nvidia.com>
|
🎉 This issue has been resolved in version 0.1.2 🎉 The release is available on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename message body definitions from
*Messageto*Eventand addedEventBasewithValidation()usingSystem.ComponentModel.DataAnnotations.Validation is done recursively for all properties and validates all validation attributes.
Status
Ready
Types of changes