Skip to content

Additional FailureReasons - #11

Merged
mocsharp merged 1 commit into
release/0.1.0from
vchang/add_failure_reasons
Apr 14, 2022
Merged

Additional FailureReasons#11
mocsharp merged 1 commit into
release/0.1.0from
vchang/add_failure_reasons

Conversation

@mocsharp

@mocsharp mocsharp commented Apr 14, 2022

Copy link
Copy Markdown
Collaborator

Description

Add additional enum values to FailureReasons: PluginError, and ExternalServiceError

Status

*Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.

@mocsharp mocsharp added the enhancement New feature or request label Apr 14, 2022
@mocsharp mocsharp added this to the 0.1.0 milestone Apr 14, 2022
@mocsharp mocsharp self-assigned this Apr 14, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
mocsharp force-pushed the vchang/add_failure_reasons branch from 596ebd9 to b2f0820 Compare April 14, 2022 18:25
@mocsharp
mocsharp changed the base branch from main to release/0.1.0 April 14, 2022 18:25
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov

codecov Bot commented Apr 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #11 (b2f0820) into release/0.1.0 (11f1ea7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.1.0         #11   +/-   ##
=================================================
  Coverage       95.65217%   95.65217%           
=================================================
  Files                 28          28           
  Lines                644         644           
  Branches              32          32           
=================================================
  Hits                 616         616           
  Misses                21          21           
  Partials               7           7           
Flag Coverage Δ
unittests 95.65217% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f1ea7...b2f0820. Read the comment docs.

@whoisj whoisj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :shipit:

@mocsharp
mocsharp merged commit e663969 into release/0.1.0 Apr 14, 2022
@mocsharp
mocsharp deleted the vchang/add_failure_reasons branch April 14, 2022 19:34
jeanpatrickleger pushed a commit that referenced this pull request Jun 14, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: JP LEGER <jeanpatrick.leger@gmail.com>
mocsharp added a commit that referenced this pull request Jun 27, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
mocsharp added a commit that referenced this pull request Jun 27, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@github-actions

Copy link
Copy Markdown

🎉 This issue has been resolved in version 0.1.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants