294 Update Spleen bundle with new interface #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nic-Ma
approved these changes
Mar 23, 2023
|
/build |
1 similar comment
|
/build |
Nic-Ma
reviewed
Mar 24, 2023
| "$import torch.distributed as dist", | ||
| "$dist.init_process_group(backend='nccl')", | ||
| "dist.is_initialized() or dist.init_process_group(backend='nccl')", |
There was a problem hiding this comment.
Hi @yiheng-wang-nv ,
Have you really tested this change?
I think you missed the "$" symbol by mistake.
Thanks.
8 tasks
yiheng-wang-nv
added a commit
that referenced
this pull request
Mar 24, 2023
part of #294 . ### Description This PR is used to fix the typo comes from #331 . ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`).
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
part of Project-MONAI#294 ### Description This PR modifies `spleen_ct_segmentation` with new interface. All scripts and commands in the readme are checked locally. ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [x] In-line docstrings updated. - [x] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [x] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [x] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [x] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [x] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [x] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`).
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
…MONAI#335) part of Project-MONAI#294 . ### Description This PR is used to fix the typo comes from Project-MONAI#331 . ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #294
Description
This PR modifies
spleen_ct_segmentationwith new interface. All scripts and commands in the readme are checked locally.Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").