You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
PyType step in CI is a no-op (echo instead of running pytype) #1917
echo only prints the command; it never runs pytype. So static type checking has silently been disabled in CI.
Why it's hard to just turn on
runtests.sh --pytype runs pytype over the whole monailabel package with strict settings (check_attribute_types, check_container_types, check_parameter_types). Because it has never run in CI, there is a backlog of pre-existing type errors. Simply removing the echo would make the build job fail on those unrelated errors.
Suggested fix
Turn the step into a real $(pwd)/runtests.sh --pytype.
Triage and fix the pre-existing pytype errors (or reduce the strictness / scope) in the same change.
Filed separately from the fix so the type-error backlog can be addressed without blocking unrelated PRs.
Activity
fix(ci): resolve pre-existing CI failures