Skip to content

PyType step in CI is a no-op (echo instead of running pytype) #1917

Open

Description

@garciadias

Problem

The PyType step in the build job of .github/workflows/pythonapp.yml is:

- name: PyType
  run: |
    echo $(pwd)/runtests.sh --pytype

echo only prints the command; it never runs pytype. So static type checking has silently been disabled in CI.

Why it's hard to just turn on

runtests.sh --pytype runs pytype over the whole monailabel package with strict settings (check_attribute_types, check_container_types, check_parameter_types). Because it has never run in CI, there is a backlog of pre-existing type errors. Simply removing the echo would make the build job fail on those unrelated errors.

Suggested fix

  1. Turn the step into a real $(pwd)/runtests.sh --pytype.
  2. Triage and fix the pre-existing pytype errors (or reduce the strictness / scope) in the same change.

Filed separately from the fix so the type-error backlog can be addressed without blocking unrelated PRs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions