Skip to content

CI packaging job fails building OHIF Viewer plugin (missing patch-package / workbox-webpack-plugin) #1916

Open

Description

@garciadias

Problem

The packaging job in .github/workflows/pythonapp.yml has been failing on main. It runs BUILD_OHIF=true python setup.py sdist bdist_wheel, which invokes plugins/ohifv3/build.sh, which clones OHIF/Viewers at pinned commit d8ef36ed and runs yarn install.

The yarn install fails with two missing-module errors:

  1. patch-package: not found — @kitware/vtk.js@32.12.0 declares a postinstall: "patch-package" script, but patch-package is not installed in the Viewers workspace (the monai-label extension is symlinked in and does not declare it).

  2. Cannot find module 'workbox-webpack-plugin' — the OHIF platform app's PWA webpack config references workbox-webpack-plugin, which is not installed.

Both are pre-existing and unrelated to any application code change.

Evidence

packaging (3.12) job log (run 38278663684):

error .../plugins/ohifv3/Viewers/extensions/monai-label/node_modules/@kitware/vtk.js: Command failed.
Command: patch-package
/bin/sh: 1: patch-package: not found
...
[webpack-cli] Error: Cannot find module 'workbox-webpack-plugin'

Suggested fix

  • Ensure patch-package is a dependency (or devDependency with --production=false) in the monai-label extension's package.json, or install it in plugins/ohifv3/build.sh before yarn install.
  • Add workbox-webpack-plugin to the OHIF platform app's dependencies (via the existing plugins/ohifv3/extensions.patch applied to the cloned Viewers tree), or pin to a Viewers commit that includes it.

This is frontend/Node build infrastructure, not Python — filed so the maintainers can decide the right pin/version.

Activity

  1. garciadias commented on Oct 12, 2026

    @garciadias
    Author

    Correction to the description above: the OHIF build failure does not by itself fail the packaging job. setup.py runs plugins/ohifv3/build.sh with subprocess.call and ignores the exit code, so the job continues and builds a wheel with no OHIF static files (cp: cannot stat 'platform/app/dist/'). The job itself was failing at "Verify Package" because the wheel was missing runtime dependencies (see #1919, fixed in #1915).

    Two things still need fixing here: the OHIF build itself (patch-package, workbox-webpack-plugin), and, arguably, setup.py should fail when BUILD_OHIF=true and the build fails, so a wheel without the viewer can't be published by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions