-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
909 IO factory - develop ITKReader, NibabelReader, LoadImage #893
Conversation
/black |
/black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nic-Ma this looks great! 🥇
I added a few suggestions inline that may be helpful.
Hi @thewtex , Thanks for your review here! Thanks. |
/black |
/black |
/black |
/black |
/black |
Hi @wyli , I updated PR according to your comments. Thanks. |
Looks good to me! If MONAI starts using Brad G's idea of an "experiment" file (perhaps quite similar to the MONAI global configuration file mentioned in this PR), then that experiment file might also influence which readers are used, but I think it could be easily added and is conceptually consistent with what was done here. Overall, this looks outstanding!!! |
/black |
/black |
/black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Nic-Ma
Hi @wyli , Thanks for your fix for the |
part of #856 #909 .
Description
This PR refactor the image loader of MONAI to support different loaders.
It can support most of common medical image format, so no need to use different loader for different images.
It's just a beginner PR, also need to change
NiftiWriter
,NiftiSaver
,PNGWriter
,PNGSaver
,Spacing
transform,Orientation
transform, etc.I didn't delete
LoadNifti
,LoadPNG
for compatibility and many examples and tests use them.Status
Ready
Types of changes
./runtests.sh --codeformat --coverage
.make html
command in thedocs/
folder.