Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8110 update highlights page for v1.4 #8111

Merged
merged 21 commits into from
Oct 14, 2024
Merged

8110 update highlights page for v1.4 #8111

merged 21 commits into from
Oct 14, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 25, 2024

Part of #8110

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
part of Project-MONAI#8110
57e1adf 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
minor fix
769851f 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu marked this pull request as draft September 25, 2024 09:57
Nic-Ma
Nic-Ma approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I would suggest to add these applications and beautiful charts into highlights:
https://docs.monai.io/en/stable/applications.html

Thanks.

KumoLiu and others added 2 commits September 27, 2024 14:25
@KumoLiu
update highlight for vista2d and add figures
81da6fc 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
de86bdd 
for more information, see https://pre-commit.ci
@KumoLiu
address comments
17045c3 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'dev' into highlight
f5e307c
@KumoLiu KumoLiu marked this pull request as ready for review October 8, 2024 06:42
@KumoLiu
minor fix
98581e9 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
update figures
498f23d 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
remove quote NVIDIA
e100001 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
add trt highlight info
8c44e32 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix typo
20768b5 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod
Copy link
Member

I had a few minor corrections but otherwise looks good, thanks!

KumoLiu and others added 7 commits October 13, 2024 14:14
@KumoLiu @ericspod
Update docs/source/whatsnew_1_4.md
b3bcb37 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu @ericspod
Update docs/source/whatsnew_1_4.md
49c9688 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu @ericspod
Update docs/source/whatsnew_1_4.md
76f234e 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu @ericspod
Update docs/source/whatsnew_1_4.md
cbfbfac 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu @ericspod
Update docs/source/whatsnew_1_4.md
91483e0 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu @ericspod
Update docs/source/whatsnew_1_4.md
c767ebc 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'dev' into highlight
3d6f396
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Oct 14, 2024

/build

@KumoLiu KumoLiu merged commit c56cfe7 into Project-MONAI:dev Oct 14, 2024
28 checks passed
@KumoLiu KumoLiu deleted the highlight branch October 14, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zephyrie zephyrie zephyrie left review comments

@SachidanandAlle SachidanandAlle SachidanandAlle left review comments

@mingxin-zheng mingxin-zheng mingxin-zheng left review comments

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@dongyang0122 dongyang0122 Awaiting requested review from dongyang0122

@guopengf guopengf Awaiting requested review from guopengf

@heyufan1995 heyufan1995 Awaiting requested review from heyufan1995

@Can-Zhao Can-Zhao Awaiting requested review from Can-Zhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KumoLiu @ericspod @zephyrie @SachidanandAlle @mingxin-zheng @Nic-Ma