-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vista3d inferers #8021
Add vista3d inferers #8021
Conversation
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
…I into add-vista3d-other-utils
for more information, see https://pre-commit.ci
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
…I into add-vista3d-other-utils
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the docstrings! I don't have other suggestions on this PR.
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
for more information, see https://pre-commit.ci
/build |
1 similar comment
/build |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me, and only had a minor comment below. Thanks!
Hi @heyufan1995 and @yiheng-wang-nv, could you please help take a look at this ci error and also address @mingxin-zheng's comments, then I can trigger more tests and merge the PR. Thanks. |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.