Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vista3d inferers #8021

Merged
merged 37 commits into from
Aug 26, 2024
Merged

Conversation

heyufan1995
Copy link
Member

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv and others added 6 commits August 16, 2024 20:47
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
@KumoLiu KumoLiu added this to the VISTA 3D [P0 v1.4] milestone Aug 19, 2024
yiheng-wang-nv and others added 2 commits August 19, 2024 15:26
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
monai/apps/vista3d/inferer.py Show resolved Hide resolved
monai/apps/vista3d/inferer.py Outdated Show resolved Hide resolved
monai/apps/vista3d/transforms.py Show resolved Hide resolved
monai/apps/vista3d/transforms.py Outdated Show resolved Hide resolved
monai/apps/vista3d/transforms.py Outdated Show resolved Hide resolved
monai/apps/vista3d/transforms.py Outdated Show resolved Hide resolved
monai/apps/vista3d/transforms.py Outdated Show resolved Hide resolved
heyufan1995 and others added 6 commits August 20, 2024 11:09
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docstrings! I don't have other suggestions on this PR.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 21, 2024

/build

heyufan1995 and others added 2 commits August 21, 2024 17:00
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv and others added 5 commits August 22, 2024 16:40
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 23, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 23, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 23, 2024

[2024-08-23T07:19:14.039Z] ======================================================================
[2024-08-23T07:19:14.039Z] ERROR: test_result_0 (tests.test_vista3d_transforms.TestVistaPostTransformd)
[2024-08-23T07:19:14.039Z] ----------------------------------------------------------------------
[2024-08-23T07:19:14.039Z] Traceback (most recent call last):
[2024-08-23T07:19:14.039Z]   File "/usr/local/lib/python3.9/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-08-23T07:19:14.039Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-08-23T07:19:14.039Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_vista3d_transforms.py", line 89, in test_result
[2024-08-23T07:19:14.039Z]     result = transform(input_data)
[2024-08-23T07:19:14.039Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/vista3d/transforms.py", line 170, in __call__
[2024-08-23T07:19:14.039Z]     pred[pred == frac] = data["label_prompt"][i - 1].to(pred.dtype)
[2024-08-23T07:19:14.039Z] RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
[2024-08-23T07:19:14.039Z] 
[2024-08-23T07:19:14.039Z] ----------------------------------------------------------------------
[2024-08-23T07:19:14.039Z] Ran 15586 tests in 1326.707s

Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, and only had a minor comment below. Thanks!

monai/apps/vista3d/inferer.py Show resolved Hide resolved
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 26, 2024

Hi @heyufan1995 and @yiheng-wang-nv, could you please help take a look at this ci error and also address @mingxin-zheng's comments, then I can trigger more tests and merge the PR. Thanks.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 26, 2024

/build

@KumoLiu KumoLiu merged commit 872585d into Project-MONAI:dev Aug 26, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants